Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum versions of optional dependencies during installation #87

Merged
merged 6 commits into from
Oct 16, 2024

Conversation

jguittard
Copy link
Contributor

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

While trying to install skeleton on PHP 8.3.x environment, current laminas-log dependency (2.16) fails. This PR relies on laminas/laminas-log:2.17 and bumps latest stable dependencies on laminas-skeleton-installer

@jguittard jguittard force-pushed the feat/composer-bumps branch from 636d65c to 7e44660 Compare October 13, 2024 13:08
Copy link
Member

@alexmerlin alexmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the tiny issue with the line ending in .gitattributes, LGTM!

.gitattributes Outdated Show resolved Hide resolved
@samsonasik
Copy link
Member

@jguittard jguittard force-pushed the feat/composer-bumps branch from 32d5a94 to 1e0eae0 Compare October 16, 2024 10:19
.gitignore Outdated Show resolved Hide resolved
Signed-off-by: Julien Guittard <[email protected]>
Signed-off-by: Julien Guittard <[email protected]>
Signed-off-by: Julien Guittard <[email protected]>
This reverts commit 8f4dd91.

Signed-off-by: Julien Guittard <[email protected]>
Signed-off-by: Julien Guittard <[email protected]>
This reverts commit 1e0eae0.

Signed-off-by: Julien Guittard <[email protected]>
@jguittard jguittard force-pushed the feat/composer-bumps branch from 08f4dba to 0859e41 Compare October 16, 2024 14:40
@gsteel gsteel added this to the 2.4.0 milestone Oct 16, 2024
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jguittard :)

@gsteel gsteel self-assigned this Oct 16, 2024
@gsteel gsteel changed the title feat: bumped composer deps Bump minimum versions of optional dependencies during installation Oct 16, 2024
@gsteel gsteel merged commit a16c25d into laminas:2.4.x Oct 16, 2024
10 checks passed
@froschdesign froschdesign mentioned this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants